Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1874935 - Add new glean-server library to define pings for server-side Glean #717

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

badboy
Copy link
Member

@badboy badboy commented Mar 21, 2024

Right now this just re-uses the Glean SDK repo and its defintions of all builtin pings.
Technically server-side Glean would only send the events ping.

Should we:

  1. Create a server-side-pings.yaml in the Glean SDK to reference here?
  2. Create a server-side-pings.yaml in the glean_parser repo to reference here (as that's where all the code for server-side lives)
  3. Create a mozilla/glean-server repository that only exists for that file?

@akkomar
Copy link
Contributor

akkomar commented Mar 29, 2024

I think either of the alternative options is preferable over reusing glean-core/pings.yaml to avoid showing unused pings in Glean Dictionary. Since the server component does not use the SDK I'd lean towards option 2, but they all seem fine and are easy to change later.

@badboy
Copy link
Member Author

badboy commented Apr 11, 2024

python3 -m probe_scraper.runner --dry-run --cache-dir tmp/cache --out-dir tmp/out --glean --glean-limit-date 2024-04-01 --output-bucket=gs://probe-scraper-prod-artifacts/ --glean-repo glean-server --glean-repo accounts-backend --glean-repo moso-mastodon-backend

looking good.

@badboy badboy merged commit 0a68e4d into mozilla:main Apr 11, 2024
2 checks passed
@badboy badboy deleted the push-smrupuslqztp branch April 11, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants