This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Explicitly import functools.reduce to play well with py3k. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see how this could cause new flaky tests. functools.reduce == builtins reduce in Python 2. Besides, parallel-simple.mk looks somewhat flaky to me. |
indygreg
added a commit
that referenced
this pull request
Jun 30, 2014
Explicitly import functools.reduce to play well with py3k.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is a little silly, but I wanted to keep it isolated.
As it turns out, that might be a good idea, because I'm suddenly seeing a test going flaky: parallel-simple.mk fails sometimes with this patch applied, and I haven't seen it fail before.
I can't see how this patch would cause any trouble there, and the test looks rather timing-sensitive, so I'm going to blame my antivirus for now.
Just reject it if you feel uncomfortable, and I can reimplement the single use of reduce() with a plain loop or something.