This repository has been archived by the owner on Aug 20, 2018. It is now read-only.
Use contains for checking titles to support staging site #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,6 +17,12 @@ class BasePage(Page): | |||
| _page_title_locator = (By.CSS_SELECTOR, 'h1.section-title') | |||
|
|
|||
| @property | |||
| def is_the_current_page(self): | |||
There was a problem hiding this comment.
shouldn't this be in page.py? or this method means to overwrite that one?
There was a problem hiding this comment.
Good point. Fixed.
|
Except the minor nits, lgtm. I ran the tests and got the same fails as in Jenkins. |
Remove unused imports
|
I have pushed changes to address the comments above. |
|
Lgtm. |
|
r+, merging in. |
stephendonner
added a commit
that referenced
this pull request
Jul 16, 2013
Use contains for checking titles to support staging site
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the is_current_page tests on quality.allizom.org, however the link checking tests are still expected to fail as these are not currently using a proxy server.