Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No readability results for https://www.mozilla.org/en-US/firefox/39.0a2/firstrun/ #143

Closed
pdehaan opened this issue Apr 15, 2015 · 2 comments
Closed

No readability results for https://www.mozilla.org/en-US/firefox/39.0a2/firstrun/ #143

pdehaan opened this issue Apr 15, 2015 · 2 comments
Labels
correctly-detected-but-reader-mode-fails has-website-testcase

Comments

@pdehaan
Copy link
Contributor

pdehaan commented Apr 15, 2015

Was testing something in Aurora and noticed that https://www.mozilla.org/en-US/firefox/39.0a2/firstrun/ (default page for new profile) shows me a reader view icon in the address bar, but clicking it shows:

"Failed to load article from page"

failed_to_load_article_from_page_and_new_issue_ _mozilla_readability_and_untitled_3
@pdehaan pdehaan mentioned this issue Apr 15, 2015
Closed
@n1k0
Copy link
Contributor

n1k0 commented Apr 16, 2015

My WIP patch in #142 seems to fix this:

screen shot 2015-04-16 at 08 53 27

n1k0 added a commit that referenced this issue Apr 24, 2015
@n1k0
Fixes #139 #143: Added more weight to section tags.
f6ffa6a
@n1k0 n1k0 mentioned this issue Apr 24, 2015
Merged
gijsk added a commit that referenced this issue Apr 24, 2015
@gijsk
Merge pull request #185 from mozilla/score-section-tags-by-default
49e4076 
Fixes #139 #143: Added more weight to section tags.
@n1k0
Copy link
Contributor

n1k0 commented Apr 29, 2015

This has been fixed by #185.

@n1k0 n1k0 closed this as completed Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
correctly-detected-but-reader-mode-fails has-website-testcase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@n1k0 @gijsk @pdehaan