Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't strip class names and ids from article content #184

Closed
leibovic opened this issue Apr 24, 2015 · 0 comments
Closed

Don't strip class names and ids from article content #184

leibovic opened this issue Apr 24, 2015 · 0 comments
Assignees

Comments

@leibovic
Copy link
Contributor

Right now we inconsistently maintain class names on readability content. It looks like the original intention was to actually strip all these class names from content, but we've found that preserving them can be useful for applying styles to common class names (e.g. .visibility-hidden should be hidden).

Now that we landed https://bugzilla.mozilla.org/show_bug.cgi?id=1154028, these class names shouldn't interfere with the reader view controls, so we could try to preserve even more class names for more special CSS rules.

@leibovic leibovic self-assigned this Apr 24, 2015
gijsk added a commit that referenced this issue Apr 24, 2015
Fixes #184 - Don't strip class names from article content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant