This repository has been archived by the owner on Nov 11, 2019. It is now read-only.
Add Datadog timers for Active Data requests #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
La0
force-pushed
the
ccov-timers
branch
2 times, most recently
from
7218271
to
25131e5
Compare
marco-c
reviewed
Oct 16, 2018
| else: | ||
| logger.info('No datadog credentials') | ||
|
|
||
| # Must be instanciated after initialize |
marco-c
reviewed
Oct 16, 2018
| @@ -95,7 +109,7 @@ def base_query(filters=[], excludes=[]): | |||
| ] | |||
| ) | |||
|
|
|||
| async with ActiveDataClient() as es: | |||
| async with ActiveDataClient('list_tests') as es: | |||
There was a problem hiding this comment.
Nit: maybe there's a way to automatically use the function name here, so we don't have to manually specify the name?
marco-c
reviewed
Oct 16, 2018
| if self.start_time is not None: | ||
| query_time = time.time() - self.start_time | ||
| stats.histogram('codecoverage.active_data.{}'.format(self.name), query_time) | ||
| logger.info('ActiveData ES query {} took {}'.format(self.name, query_time)) |
There was a problem hiding this comment.
Is there a way to get the actualy query time (that is, the ES query time, without the network time).
marco-c
approved these changes
Oct 16, 2018
marco-c
reviewed
Oct 16, 2018
| @@ -21,6 +23,7 @@ | |||
| ''' | |||
|
|
|||
|
|
|||
| @stats.timed('codecoverage.active_data.coverage_paths') | |||
There was a problem hiding this comment.
This should be redundant now that there's a timer in search.
marco-c
reviewed
Oct 16, 2018
| @@ -61,12 +64,13 @@ def search(self, name, body, timeout=10): | |||
| def enabled(self): | |||
| return self.client is not None | |||
|
|
|||
| @stats.timed('codecoverage.active_data.get_latest_changeset') | |||
There was a problem hiding this comment.
This should be redundant now that there's a timer in search.
marco-c
approved these changes
Oct 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1471