This repository has been archived by the owner on Oct 28, 2020. It is now read-only.
[833026] Multiple event attendees should be a grid #1086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mte90 Thanks for this PR! I 'll review this asap. |
|
there also this #1085 :-) |
|
For html files we are using two spaces for indentation and not four. |
| </p> | ||
| {% if attendee.count >= 3 %} | ||
| <div class="row"> | ||
| {% macro display_attendee(attendee) -%} |
There was a problem hiding this comment.
There is no need to define a second macro here. You can use the if/else statement inside the existing macro.
|
any news for that? |
|
This pr is tested on a real environment and now works. |
|
Ok i have merged all the commits |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=833026
I can't try because I've some problems locally with the login/redirect but I think that is correct.