This repository has been archived by the owner on Oct 28, 2020. It is now read-only.
[fix bug 1288802] Misplaced down arrow, in select initiave dropbox #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
comzeradd
suggested changes
Apr 6, 2017
There was a problem hiding this comment.
Thanks @tsmrachel for working on this!
Could you amend the margins of .required-field to be lower and closer to the relevant input field? Now it seems a bit off. Also in some fields it's significantly misaligned, displayed too high compared to the field. See the screenshots bellow.
|
|
comzeradd
suggested changes
Apr 6, 2017
| .required-field-input { | ||
| &:extend(.required-field); | ||
| left: 5px; | ||
| top: 10px; |
There was a problem hiding this comment.
Same here: try top: 18px.
| .required-field { | ||
| &:extend(.required-field); | ||
| left: 5px; | ||
| top:0; |
There was a problem hiding this comment.
Minor tweak: try this to be top: 10px, so it's vertical aligned to the middle of the input field.
There was a problem hiding this comment.
if it's to be vertical aligned to the middle, do you mean
.required-field-input top: 20px
.required-field top: 18px
top: 20px
top: 10px
comzeradd
approved these changes
Apr 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1288802