[Fix bug 836981] Remove WebTrends add Google Analytics #357
Conversation
|
Please add the bug number at the beginning of the commit message, e.g. [fix bug BugId]. |
| var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s); | ||
| })(); | ||
|
|
||
| </script> No newline at end of file |
There was a problem hiding this comment.
Just a thought, maybe you could use something like this
https://github.com/mozilla/mozillians/blob/master/templates/includes/google_analytics.html
where GA_ACCOUNT_CODE is stored in settings/local.py, with the actual key
only on the production server, so that we can avoid hits from local instances, dev and stage servers.
You can also update base.py with GA_ACCOUNT_CODE = None.
There was a problem hiding this comment.
We restrict this data in google analytics using a filter, so no data from local dev or stage will show up in reports.
This is only used in one place so I am not sure if we want to add it to settings.
Thoughts?
There was a problem hiding this comment.
In that case, please ignore my previous comment.
|
Git commit message updated. |
|
r+ 🍺 |
[Fix bug 836981] Remove WebTrends add Google Analytics
Note I did not see the need to add the GA code to settings. This code only appears in a single place.