Skip to content
This repository has been archived by the owner on Oct 28, 2020. It is now read-only.

[fix bug 940277] [fix bug 931068] Active report template and view. #562

Merged
merged 2 commits into from
Dec 10, 2013

Conversation

akatsoulas
Copy link
Contributor

  • Build the UI fro viewing reports.
  • Build the back-end for viewing reports.

</div>
<section class="large-11 columns report-item">
<h4>Date of activity</h4>
<time pubdate="YYYY-MM-DD">{{ report.report_date|strftime('%d %b %Y') }}</time>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch pubdate attribute to datetime (typo on my part, sorry).

The value of the datetime attribute should be set to the report date, e.g. 2013-12-13

@glogiotatidis
Copy link
Contributor

This looks good. Let's fix these comments and I'll do another pass. Thanks for the good tests!

@akatsoulas
Copy link
Contributor Author

@glogiotatidis @alexgibson
Regarding the time format in the template, we are using the format %d %b %Y (eg 10 Dec 2013) in the submission form. Should we stick to that here too or shall we change to something like YY-MM-DD ?

@glogiotatidis
Copy link
Contributor

current format is nice imho

@alexgibson
Copy link
Member

I think as long as we are sticking to the ISO date format (YYYY/MM/DD) in the submission form, then it is fine to display here in the template in a more readable way :)

@akatsoulas
Copy link
Contributor Author

@alexgibson @glogiotatidis
PR updated

</div>

<!-- Campaign participated in -->
{% if report.campaign %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking page layout if no campaign is participated in (and also hiding the activity date).

Perhaps just wrap this block around <div class="row report-box"> on line 80.

@glogiotatidis
Copy link
Contributor

r+ 🎉 Thanks!

akatsoulas added a commit that referenced this pull request Dec 10, 2013
[fix bug 940277] [fix bug 931068] Active report template and view.
@akatsoulas akatsoulas merged commit d9095a4 into mozilla:master Dec 10, 2013
@akatsoulas akatsoulas deleted the 940277 branch December 22, 2013 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants