-
Notifications
You must be signed in to change notification settings - Fork 104
[fix bug 940277] [fix bug 931068] Active report template and view. #562
Conversation
akatsoulas
commented
Dec 9, 2013
- Build the UI fro viewing reports.
- Build the back-end for viewing reports.
</div> | ||
<section class="large-11 columns report-item"> | ||
<h4>Date of activity</h4> | ||
<time pubdate="YYYY-MM-DD">{{ report.report_date|strftime('%d %b %Y') }}</time> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch pubdate
attribute to datetime
(typo on my part, sorry).
The value of the datetime
attribute should be set to the report date, e.g. 2013-12-13
This looks good. Let's fix these comments and I'll do another pass. Thanks for the good tests! |
@glogiotatidis @alexgibson |
current format is nice imho |
I think as long as we are sticking to the ISO date format (YYYY/MM/DD) in the submission form, then it is fine to display here in the template in a more readable way :) |
@alexgibson @glogiotatidis |
</div> | ||
|
||
<!-- Campaign participated in --> | ||
{% if report.campaign %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is breaking page layout if no campaign is participated in (and also hiding the activity date).
Perhaps just wrap this block around <div class="row report-box">
on line 80.
r+ 🎉 Thanks! |
[fix bug 940277] [fix bug 931068] Active report template and view.