Attach jsdoc nodes to function params #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any objections to this pull? it would be nice to get the Closure Compiler's rhino "un-forked" again? |
|
Closure Compiler no longer uses rhino as a parser. Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from the review on Reviewable.io |
|
This looks like a very old but reasonable fix. |
|
hahahaha, i'm sure you're setting some sort of record with these merges :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully, this should be a straightforward and non-controversial parser change. Thanks!