Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply spotlessApply to all code #1159

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Conversation

tuchida
Copy link
Contributor

@tuchida tuchida commented Jan 18, 2022

ref. #1024

diff --git a/build.gradle b/build.gradle
@@ -440,7 +440,6 @@ spotbugs {
 }
 
 spotless {
-    ratchetFrom 'code-formatting-required'
     java {
         googleJavaFormat().aosp()
     }

I ran ./gradlew spotlessApply in this state.

@p-bakker p-bakker requested a review from gbrail January 20, 2022 08:29
@p-bakker
Copy link
Collaborator

@gbrail @rbri thoughts? Can this be merged so we're done with all the reformatting and PR's can be cleaner?

@gbrail
Copy link
Collaborator

gbrail commented Jan 27, 2022

I'd like to catch up with the current backlog of PRs over the next day or two, at which point I'll either try to merge this or create my own PR!

apply spotless for all code
@p-bakker
Copy link
Collaborator

Not sure if it should be tackled at the same time as this PR or not, but as part of #1120 it was suggested to also make line endings consistent, see a proposal here.

I guess the reason for wanting to combine the two is that is means files only need to be touched once? But if we stick to unix line endings (contrary to the earlier proposed switch to Windows line endings) files wouldn't have to change as they already use unix line endings

@gbrail
Copy link
Collaborator

gbrail commented Jan 28, 2022

I'd rather deal with the line endings separately (I'm still not sure that we need to change anything). Let's merge this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants