two json stringify fixes #1209
Merged
two json stringify fixes #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-bakker
reviewed
Apr 14, 2022
| @@ -294,10 +294,17 @@ private static Object str(Object key, Scriptable holder, StringifyState state) { | |||
| value = getProperty(holder, ((Number) key).intValue()); | |||
| } | |||
|
|
|||
| if (ScriptRuntime.isSymbol(value)) return Undefined.instance; | |||
There was a problem hiding this comment.
Is this correct, from an EcmaScript pov, that this is here, before the toJSON call or the call to the replacer (if provided)?
There was a problem hiding this comment.
Will have a look - good point
There was a problem hiding this comment.
@p-bakker you are right here - update is on the way. Many thanks for the review.
p-bakker
reviewed
Apr 19, 2022
p-bakker
reviewed
Apr 19, 2022
|
PR looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.