Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hasOwnProperty on NativeJavaObject #1255

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

Schmidor
Copy link
Contributor

This failed since #1157 with "TypeError: Expected argument of type
object, but instead had type object"

org.mozilla.javascript.EcmaError: TypeError: Expected argument of type object, but instead had type object (#1)
	at org.mozilla.javascript.ScriptRuntime.constructError(ScriptRuntime.java:4568)
	at org.mozilla.javascript.ScriptRuntime.constructError(ScriptRuntime.java:4549)
	at org.mozilla.javascript.ScriptRuntime.typeError(ScriptRuntime.java:4581)
	at org.mozilla.javascript.ScriptRuntime.typeErrorById(ScriptRuntime.java:4586)
	at org.mozilla.javascript.ScriptableObject.ensureScriptableObject(ScriptableObject.java:1845)
	at org.mozilla.javascript.AbstractEcmaObjectOperations.hasOwnProperty(AbstractEcmaObjectOperations.java:37)
	at org.mozilla.javascript.NativeObject.execIdCall(NativeObject.java:216)
	at org.mozilla.javascript.IdFunctionObject.call(IdFunctionObject.java:84)
	at org.mozilla.javascript.ScriptRuntime.applyOrCall(ScriptRuntime.java:2769)
	at org.mozilla.javascript.BaseFunction.execIdCall(BaseFunction.java:327)
	at org.mozilla.javascript.IdFunctionObject.call(IdFunctionObject.java:84)
	at org.mozilla.javascript.optimizer.OptRuntime.call2(OptRuntime.java:46)
	at org.mozilla.javascript.gen.c_1._c_script_0(:1)
	at org.mozilla.javascript.gen.c_1.call()
	at org.mozilla.javascript.ContextFactory.doTopCall(ContextFactory.java:383)
	at org.mozilla.javascript.ScriptRuntime.doTopCall(ScriptRuntime.java:3871)
	at org.mozilla.javascript.gen.c_1.call()
	at org.mozilla.javascript.gen.c_1.exec()
	at org.mozilla.javascript.Context.evaluateString(Context.java:1170)
	at org.mozilla.javascript.tests.NativeObjectTest.testNativeJavaObject_hasOwnProperty(NativeObjectTest.java:100)

@Schmidor Schmidor force-pushed the hasOwnProperty branch 2 times, most recently from bec677b to cce5363 Compare August 17, 2022 12:21
This failed since mozilla#1157 with "TypeError: Expected argument of type
object, but instead had type object"
@p-bakker
Copy link
Collaborator

p-bakker commented Sep 5, 2022

LGTM

@p-bakker p-bakker requested review from rbri and gbrail September 5, 2022 07:12
@p-bakker p-bakker added this to In progress in v1.7.xx via automation Sep 5, 2022
@gbrail
Copy link
Collaborator

gbrail commented Oct 29, 2022

This looks good -- thanks for finding, fixing, and writing a test!

@gbrail gbrail merged commit b99e5ee into mozilla:master Oct 29, 2022
v1.7.xx automation moved this from In progress to Done Oct 29, 2022
@Schmidor Schmidor deleted the hasOwnProperty branch October 31, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants