Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function prototype properties length and name are configurable (in ES6) #1284

Merged
merged 5 commits into from
Nov 30, 2022

Conversation

rbri
Copy link
Collaborator

@rbri rbri commented Nov 26, 2022

No description provided.

@p-bakker
Copy link
Collaborator

LGTM

@rbri
Copy link
Collaborator Author

rbri commented Nov 27, 2022

i think we should squash this pr

@p-bakker
Copy link
Collaborator

Still LGTM and agree about the squash

@gbrail
Copy link
Collaborator

gbrail commented Nov 30, 2022

This looks great to me too. Thanks for tracking it down!

@gbrail gbrail merged commit cbf8333 into mozilla:master Nov 30, 2022
@gbrail
Copy link
Collaborator

gbrail commented Nov 30, 2022

I wanted to squash this, and I fat-fingered the merge. But I don't want to do anything awful to the repo so it'll have to stay. Thanks for fixing.

@rbri rbri deleted the FunctionProto_length_configurable branch November 30, 2022 07:27
@rbri
Copy link
Collaborator Author

rbri commented Nov 30, 2022

Thanks for merging....

@p-bakker p-bakker added this to the Release 1.7.15 milestone Dec 1, 2022
@p-bakker p-bakker added the Ecma Incompatibility Issues about Rhino being incompatible with the EcmaScript spec label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ecma Incompatibility Issues about Rhino being incompatible with the EcmaScript spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants