Fix the condition for isResourceChanged

[szegedi]

I was experimenting with this code while building a bit of a showcase for my OSS work and uncovered this bug when loading code from an actual HTTP server and modifying it and testing reloading under modification.

[p-bakker]

On the face it this seems an obvious bug and straight forward fix, so from that perspective I'd say: LGTM

However: could you maybe check the open commonjs issues, to see whether this PR fixes any of them or whether there are additional fixes to be done in this area? https://github.com/mozilla/rhino/issues?q=is%3Aopen+is%3Aissue+label%3ACommonJS

[szegedi]

However: could you maybe check the open commonjs issues

Sure, I can give them a read-over. Here's the results:

#431 is similar but it was already fixed (should be closed, I guess – I can't close it as I had trouble with Mozilla's authentication changes so I lost my maintainer privileges for now.)
#198 commented on it – works as expected, I tried to explain to the user that reloading of source code doesn't affect already loaded exports
#95 WFM, I added a working example in the comments.
#55 is a feature request, supporting node.js packages in addition to CommonJS modules.
#53 and #10 are some Windows issues; #10 seems to be working as expected since the module directory needs to be an URI.

[p-bakker]

Sure, I can give them a read-over. Here's the results:

Tnx a bunch, updated all those issues accordingly

[szegedi]

Tnx a bunch, updated all those issues accordingly

Awesome. Any chance you can merge this one?

[p-bakker]

Can't, am not a committer :-/

@rbri @gbrail maybe?

[rbri]

thanks Attila