This PR fixes the issue of flush() #1358
Conversation
…ement." This reverts commit 109ab9b.
|
i guess spotless will not be happy with this but outside of that i'm fine with the change lets see what the ci has to say |
|
@rbri can you help me out here? What I need to do to make the spotless thing passed? |
|
@nmondal simply run ./gradlew spotlessApply |
Done that, figured that one out, was a bit tricky Java 8 and all.. but done now. |
|
@nmondal no i have to approve the ci run.... |
|
@rbri we have lift-off endorsements! |
|
| @@ -31,8 +31,24 @@ public void setup() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void printStdout() throws ScriptException { | |||
There was a problem hiding this comment.
@nmondal can you please bring back to old test and add you as a new one
There was a problem hiding this comment.
@rbri the old test was not testing anything.
If the old test was "correct" we would never have had the bug in the first place.
Being said that, if you still wish we can. But do we want to?
There was a problem hiding this comment.
I guess the test at least makes sure the print function is supported and works without an exception.
And it does not harm to have one more test (and it is good for the statistics :-))
There was a problem hiding this comment.
I guess the test at least makes sure the print function is supported and works without an exception. And it does not harm to have one more test (and it is good for the statistics :-))
Done. Done. Done.
🕺🏽
@rbri can you please do the honors of running the pipeline?
|
@nmondal many thanks for your PR |
As mentioned here.
#1356