fix a missing array limit check #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuchida
reviewed
Aug 13, 2023
| @@ -1656,7 +1660,14 @@ private static Scriptable js_concat( | |||
| scope = getTopLevelScope(scope); | |||
| final Scriptable result = cx.newArray(scope, 0); | |||
|
|
|||
| long length = doConcat(cx, scope, result, o, 0); | |||
There was a problem hiding this comment.
Does this need to be changed here? I verified this in my environment and the test passed with doConcat as well.
|
|
||
| /** | ||
| * @see <a | ||
| * href="https://github.com/mozilla/rhino/issues/673">https://github.com/mozilla/rhino/issues/673</a> |
There was a problem hiding this comment.
Is this comment correct? It looks to me like the issue not directly related to this Pull Request.
rbri
force-pushed
the
array_concat_limit
branch
from
86308e2
to
2dad787
Compare
|
@tuchida (and all the others) |
|
Nice fix. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found this while working on the proxy support
see built-ins/Array/prototype/concat/arg-length-exceeding-integer-limit.js