-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support unicode codepoint escape #1383
Conversation
Looks like there is a spotless violation ;-) |
Super cool progress - i like to see this merged! |
fa5276f
to
a1c57b5
Compare
Nice progress indeed!
As Java versions are tied to a specific version of Unicode, whereas the EcmaScript spec (at least as of ES2017/ES8) says the EcmaScript implementation must conform to the latest Unicode standard. And then the test262 suite is authored against the latest version of EcmaScript (but we aren't on the latest version of the 262 testsuite just yet) As such, I think some differences can occur running Rhino/tests against different Java versions |
This time I checked language version to avoid breaking compatibility as much as possible, but I would like to turn this off. |
Although the conflict between the Unicode version supported by JavaScript and the one supported by Java seems problematic, in general this looks good and I like how many more tests it fixes. Do the rest of you feel it's ready to merge? |
+1 for merge |
Agree that we should not get too hung up on any issues due to the different Unicode versions supported by Java and required by the different language versions in Rhino, but would like some more insight into the impact/specifics of 'prevent breaking compatibility' and 'In this Pull Request, the determination of characters that cannot be used as identifiers differs from the specification' @tuchida mentioned, if only to make things clear in the eventual release notes and make note of it in the docs somewhere Other than that, I think we should go ahead and merge, because it's great test262 progress |
OK, I agree. We'll want to use the message on this PR in the eventual release notes. |
I meant to squash that with a nice commit message, but didn't. I don't think that maintaining a pretty history is worth adding a bunch of revert commits or doing a force-push, so we'll have to use the original text in the PR description when writing up the release notes. |
Closes #917
Breaking change
All errors occur only when version is 200.
Incomplete unicode escape
ref. 495a74e
Escaped reserved words
ref. 32c76f8
Characters that cannot be used as identifiers
ref. a1c57b5
In this Pull Request, the determination of characters that cannot be used as identifiers differs from the specification. The reason is that
isUnicodeIdentifierStart
andisUnicodeIdentifierPart
are wrong in Java (old spec?). Java20 seems to be the same as the ECMA specification.