(Partial) implementation of [Symbol.species]
#1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec says that it needs to return `this`, not the original constructor! As a matter of fact, there's a test262 that this commit fixes (`built-ins/Promise/Symbol.species/return-value.js`)
`Map`, `Array`, `RegExp`, and `Promise`
|
@andreabergia thanks a lot. To me this looks like another step forward, have done a quick review of you changes and i'm fine. |
|
no complains, and because this is a step forward i will merge this soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does:
[Symbol.species]to various built-in objects, as required by the spec:Set(spec 24.2.2.2)Map(spec 24.1.2.3)Regex(spec 22.2.5.2)Array(spec 23.1.2.5)Promise(spec 27.2.4.9)Symbol.speciesan ignored feature; this in turn increases the feature coverage because some more tests pass.Notice that this PR does not implement the behavior of the symbol (spec 7.3.22) - it just adds the symbol to some built-ins.