Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial implementation of function rest parameter support #1451

Merged
merged 4 commits into from
Apr 28, 2024

Conversation

rbri
Copy link
Collaborator

@rbri rbri commented Feb 26, 2024

arrow functions are not supported as of now

rbri added a commit to HtmlUnit/htmlunit-rhino-fork that referenced this pull request Apr 1, 2024
@rbri
Copy link
Collaborator Author

rbri commented Apr 27, 2024

no comments for 2 months - @p-bakker, @gbrail are you still around?

@gbrail
Copy link
Collaborator

gbrail commented Apr 27, 2024

I have been having a really hard time finding time to work on Rhino these days as it's completely not part of my work world any more. Thanks for taking up a lot of the duties!

This particular PR looks good to me -- I also tried it and I can see that it handles the basics as described in the spec.

My only particular very minor comment is about the error message -- if we don't have a French translation of a particular message, can't we leave it out of the "_fr" message catalog and have Java fall back to the generic message? I see that you copied the English into the French message catalog and I don't believe that has worked in the past.

Thanks -- I am happy to merge this if we change that one tiny thing.

@rbri
Copy link
Collaborator Author

rbri commented Apr 28, 2024

@gbrail good point -done

@gbrail
Copy link
Collaborator

gbrail commented Apr 28, 2024

This looks good now -- thanks!

@gbrail gbrail merged commit 05c033d into mozilla:master Apr 28, 2024
3 checks passed
@p-bakker p-bakker added this to the Release 1.7.15 milestone May 30, 2024
@p-bakker
Copy link
Collaborator

@rbri the description says arrow functions aren't supported, but it's that (still) correct?

If arrows are also supported, I assume this PR completely closes #652?

@rbri rbri deleted the functions_rest_parameters branch May 30, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants