Support for arguments object as TypedArray constructor argument
#297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the change the following would cause `org.mozilla.javascript.EcmaError: Error: invalid argument`
```
function foo() {
return new Int32Array(arguments);
};
```
The proposed change is completely untested and should be considered more of a bug report.
|
Sorry I have not caught up on all of these. This looks like a very reasonable change but I'd really like to see a test case. |
|
Have created a new PR #457 with the same code change but including an unit test. |
gbrail
pushed a commit
that referenced
this pull request
Jul 9, 2018
this is the same as #297 but includes a simple test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change the following would cause
org.mozilla.javascript.EcmaError: Error: invalid argumentThe proposed change is completely untested and should be considered more of a bug report.