-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in JavaAdapter.java of cannot override method in multi-layer interface #857
Conversation
Could you write a unit test that shows what you are able to do? This seems to be the test for |
Supposing that the program has a java abstract class as follows and I want to extend class A and override the method methodInInterfaceC in interface C, the current method
I found this probem when I was about to extend |
Thanks. Can you write test?
I don't understand English either, so I use a translation tool. |
I still can’t use github proficiently, so I don’t know whether you mean this. |
It looks good. |
Good! Please wait a moment for the owner to confirm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! I have a few specific comments.
Also, could you update the PR description with a bit longer explanation of what changed, combined with a small example like the one in your test? That will help a lot in writing the release notes.
modify the code style to match the original project
change assert to throws
rename PullRequest857Test.java to JavaAdapterTest.java
for pull reqeuest mozilla#857
OK, you have answered lots of our questions. Thanks! |
Supposing that the program has a java abstract class as follows
This PR fixes a bug in JavaAdapter that the method
public int methodInterfaceC(String str)
cannot be overrided correctly in javascript byJavaAdapter(Packages.A,{methodInterfaceC:function(){}},null)