Generate mozcpp grammar automatically #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luni-4
force-pushed
the
grammar-script
branch
from
ead4d2a
to
6c1217c
Compare
marco-c
reviewed
Feb 11, 2021
marco-c
reviewed
Feb 11, 2021
2 tasks
Luni-4
force-pushed
the
grammar-script
branch
from
6c1217c
to
5507209
Compare
Luni-4
force-pushed
the
grammar-script
branch
from
5507209
to
73433cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
=======================================
Coverage 24.97% 24.97%
=======================================
Files 45 45
Lines 5586 5586
Branches 817 817
=======================================
Hits 1395 1395
Misses 3647 3647
Partials 544 544 Continue to review full report at Codecov.
|
marco-c
reviewed
Feb 11, 2021
marco-c
reviewed
Feb 11, 2021
Luni-4
force-pushed
the
grammar-script
branch
from
73433cf
to
180d36f
Compare
marco-c
reviewed
Feb 11, 2021
Luni-4
force-pushed
the
grammar-script
branch
from
180d36f
to
eb388f6
Compare
marco-c
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the first item of #469
Thanks in advance for your review! :)