Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

JS parsing and AST generation should be easier to switch out. #155

Closed
mozfreddyb opened this issue Aug 8, 2014 · 4 comments
Closed

JS parsing and AST generation should be easier to switch out. #155

mozfreddyb opened this issue Aug 8, 2014 · 4 comments

Comments

@mozfreddyb
Copy link

in order to run scanjs in different environments (server side, in firefox itself, etc.) it would be nice if ScanJS.scan took an ast instead of the source code string.

@callicles has suggested to take a stab at it. Thanks :)
@callicles
Copy link

Test

@mozfreddyb mozfreddyb assigned mozfreddyb and unassigned mozfreddyb Aug 8, 2014
@callicles
Copy link

After, looking more closely at it I think it would be better to allow parser setting in Scan.JS.scan. Mainly because the rules are also parsed in the scan.js file

callicles added a commit to callicles/scanjs that referenced this issue Aug 14, 2014
@callicles
mozilla#155 - add idea to gitignore
ea0be8a
callicles added a commit to callicles/scanjs that referenced this issue Aug 14, 2014
@callicles
mozilla#155 - Enabling parser change in scan.js
eb84333
@mozfreddyb
Copy link
Author

Mhh, I'd prefer some stronger sort of separation. I guess we'll have to ditch acorn.walk for that. :)

callicles added a commit to callicles/scanjs that referenced this issue Aug 17, 2014
@callicles
mozilla#155 - Working on the AST switchout, starting to migrate mocha…
58fee7a 
… tests
callicles added a commit to callicles/scanjs that referenced this issue Aug 17, 2014
@callicles
mozilla#155 - Working on mocha test migration
3f8e6d1
callicles added a commit to callicles/scanjs that referenced this issue Aug 17, 2014
@callicles
mozilla#155 - Working on fixing advanced test with new scan.js api. F…
32dc855 
…ixed a js rule not parsing correctly
callicles added a commit to callicles/scanjs that referenced this issue Aug 17, 2014
@callicles
mozilla#155 - Fixing test cases
208d48b
callicles added a commit to callicles/scanjs that referenced this issue Aug 17, 2014
@callicles
mozilla#155 - Fixing acorn check + some module loading
dc8f252
@callicles callicles mentioned this issue Aug 17, 2014
Merged
callicles added a commit to callicles/scanjs that referenced this issue Aug 25, 2014
@callicles
mozilla#155 - Change some variable name.
1eed704
@mozfreddyb
Copy link
Author

closed #156

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@callicles @mozfreddyb