Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

split scanjs into separate repos for nodejs, web and just the scanning #158

Closed
mozfreddyb opened this issue Sep 18, 2014 · 3 comments
Closed
Assignees
Labels
enhancement wontfix wontfix-repo-was-archived This issue was automatically closed as wontfix as we archived the repo.

Comments

@mozfreddyb
Copy link

This repo will remain the main repo for just the scanning, but we should move the web (server.js, client/) and nodejs-specific bits (scanner.js) to these repos:

@zombie agreed to work on this as a first step to familiarize himself with the existing code.

This has been a concern for a while, but not a filed issue. Thanks to @sole, who suggested that :)

@sole
Copy link

sole commented Sep 18, 2014

👍

@zombie
Copy link
Member

zombie commented Oct 2, 2014

so after some reading and testing with npm, dependencies, git, github and submodules, i have a slightly different proposal, based on these ideas:

  1. (assumption) users of scanjs either care about how large it is (and want only the basic lib), or they don't care at all
  2. (goal) it should be easy to use/try/deploy/contribute to the scanjs, which translates to "as few steps as possible required to start playing with it"
  3. (oppinion) we should minimize ways to mess up during development, which translates to "the fewer moving parts, the better"
  4. (fact) nodejs parts of scanjs should be usable (and probably come) with the webui part

so my suggestion is to split into just two modules, one for just the basic lib and rules (basically what's in "common" today) and then everything else. modules should be named either:

  • scanjs-core and scanjs, or
  • scanjs and scanjs-tools

the basic lib part (i vote this to be named scanjs-core) should be included as a git submodule in the bigger one. both should be independently available for getting/using either from github or npm.

still open questions:

  1. should the basic lib module include at least some test or not
    • and if so, how should the tests run? which environment? node? browser?
    • (both options have merit)
  2. people are not unanimously in love with git submodules:
    • there are some issues with development across two different repos,
    • no shared history, not able to publish to both parts of the code-base in one commit/PR
    • needing to (remember to) update the submodule pointer on every update

but i think the benefits outweigh the potential problems, of requiring users to independently track/download/maintain dependencies and possible confusion if we ever have dev and release channels..

what do you think @mozfreddyb and @pauljt ?

@zombie
Copy link
Member

zombie commented Oct 2, 2014

also, do we want to take that opportunity to transfer the official repo?

mozilla github policy states official repos should not be forks of personal repos.

@mozfreddyb mozfreddyb added wontfix wontfix-repo-was-archived This issue was automatically closed as wontfix as we archived the repo. labels Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement wontfix wontfix-repo-was-archived This issue was automatically closed as wontfix as we archived the repo.
Projects
None yet
Development

No branches or pull requests

3 participants