This repository has been archived by the owner on Sep 15, 2021. It is now read-only.
added parser exception hanlder & known libs cmdline skip switch #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. It looks really nice, but I have a few minor comments that I'll leave right in the file. |
| dive(fullpath, action); | ||
| } catch (e) { | ||
| console.log("SKIPPING FILE: Couldn't parse " + fullpath); | ||
| } |
There was a problem hiding this comment.
I closed #171, to take the patch from here. I like that you kept the consistent upper case SKIPPING FILE string. 👍
|
(NB, I kicked travis-ci, to rebuild and the previous build failure was a problem with the tests, not with your code) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #171