Feature more msvc flags parsed #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Zm can just pass through. It's related to PCH which we don't handle yet. However, Zm doesn't actually force creating a PCH, so it's not actually hard to handle independently. * Yc is compile a PCH and it's too hard right now. Adding it to too hard means better stats from the server about why it could not cache compilation. * sourceDependencies is identical to /deps, just a different name that some systems seem to prefer to use when construction MSVC compile commands.
Same flag, different name.
Alexei-Barnes
force-pushed
the
feature-more-msvc-flags-supported
branch
from
b3e9ab7
to
47db6e6
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1729 +/- ##
==========================================
+ Coverage 29.33% 29.50% +0.16%
==========================================
Files 49 49
Lines 17056 17088 +32
Branches 8272 8285 +13
==========================================
+ Hits 5004 5042 +38
+ Misses 7000 6999 -1
+ Partials 5052 5047 -5
... and 14 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing these flags improves support for caching Unreal Engine builds via sccache.
This fixes #1728.
This should improve the output for #988, but it does not add PCH support.
Added tests for
/Yc,/deps, and/sourceDependencies.Zmis just a trivial passthrough, so it didn't seem worth adding a test for. MostPassThroughWithSuffixarguments don't appear to have tests.