Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature more msvc flags parsed #1729

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Feature more msvc flags parsed #1729

merged 3 commits into from
Apr 24, 2023

Commits on Apr 13, 2023

  1. Add parsing for flags: Zm, Yc, sourceDependencies 

    * Zm can just pass through. It's related to PCH which we don't handle yet. However, Zm doesn't actually force creating a PCH, so it's not actually hard to handle independently.
* Yc is compile a PCH and it's too hard right now. Adding it to too hard means better stats from the server about why it could not cache compilation.
* sourceDependencies is identical to /deps, just a different name that some systems seem to prefer to use when construction MSVC compile commands.
    @Alexei-Barnes
    Alexei-Barnes committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    4aa8f27 View commit details
    Browse the repository at this point in the history

  2. Tests for /Fp and /Yc with MSVC 

    Same flag, different name.
    @Alexei-Barnes
    Alexei-Barnes committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    4d531d4 View commit details
    Browse the repository at this point in the history

  3. Add test for depfile flags for MSVC

    @Alexei-Barnes
    Alexei-Barnes committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    47db6e6 View commit details
    Browse the repository at this point in the history