nvcc: Handle compiler detection when gcc isn't on the path #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you have a bunch of failure in the CI :) |
To properly handle compiler detction sccache invokes the compiler with -E. To generate the preprocessed output `nvcc` invokes the host comiler, which either requires gcc to be on the path or `-ccbin` argument to be provided. This PR allows `sccache` to be used with `nvcc` when `gcc` isn't on the path but the host compiler to be used is included via `-ccbin`. This was found when building small build images which only had a compiler with a name like `gcc-aarch64`.
robertmaynard
force-pushed
the
bug/correct_ccbin_support
branch
from
5e52d1a
to
b19fc29
Compare
robertmaynard
force-pushed
the
bug/correct_ccbin_support
branch
from
3d3afdd
to
5ef97cc
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1747 +/- ##
==========================================
+ Coverage 29.22% 29.38% +0.16%
==========================================
Files 49 49
Lines 17488 17593 +105
Branches 8457 8500 +43
==========================================
+ Hits 5110 5169 +59
Misses 7252 7252
- Partials 5126 5172 +46
☔ View full report in Codecov by Sentry. |
I think I fixed all the issues and learned some more rust along the way :) |
sylvestre
reviewed
Apr 28, 2023
| } | ||
| use self::ArgData::PassThrough as Detect_PassThrough; | ||
|
|
||
| counted_array!(static ARGS: [ArgInfo<ArgData>; _] = [ |
There was a problem hiding this comment.
could you please document this a bit? :)
There was a problem hiding this comment.
Do you mean like move the documentation from 1101 up to here?
|
Or explain what this code is doing :)
Le ven. 28 avr. 2023, 17:10, Robert Maynard ***@***.***> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In src/compiler/compiler.rs
<#1747 (comment)>:
> cc.map(|c| (c, None))
}
}
+ArgData! {
+ PassThrough(OsString),
+}
+use self::ArgData::PassThrough as Detect_PassThrough;
+
+counted_array!(static ARGS: [ArgInfo<ArgData>; _] = [
Do you mean like move the documentation from 1101 up to here?
—
Reply to this email directly, view it on GitHub
<#1747 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFTBDXD4QJZZGXO2HQSUSLXDPMVTANCNFSM6AAAAAAXLDUTIY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
robertmaynard
commented
Apr 28, 2023
I have updated the general code blocks with explanations on what we are doing, and why. |
|
please run rustfmt :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To properly handle compiler detction sccache invokes the compiler with -E. To generate the preprocessed output
nvccinvokes the host comiler, which either requires gcc to be on the path or-ccbinargument to be provided.This PR allows
sccacheto be used withnvccwhengccisn't on the path but the host compiler to be used is included via-ccbin.This was found when building small build images which only had a compiler with a name like
gcc-aarch64.