Use object for parsing archives, and handle macOS fat archives

[alex]

No description provided.

[alex]

One note: this involves reading the entire archive into memory. If we want to avoid that, we can add an mmap crate to do it that way.

[drahnr]

Nice, I'd prefer the usage of mmap where possible.

[codecov-commenter]

Codecov Report

Patch coverage: 15.78% and project coverage change: -0.10 ⚠️

Comparison is base (b2faf16) 29.42% compared to head (d4b6de2) 29.33%.

❗ Current head d4b6de2 differs from pull request most recent head ca4db69. Consider uploading reports for the commit ca4db69 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1776      +/-   ##
==========================================
- Coverage   29.42%   29.33%   -0.10%     
==========================================
  Files          49       49              
  Lines       17626    17620       -6     
  Branches     8511     8506       -5     
==========================================
- Hits         5187     5168      -19     
+ Misses       7339     7334       -5     
- Partials     5100     5118      +18     

Impacted Files	Coverage Δ
src/util.rs	23.45% <15.78%> (+0.09%)	⬆️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[alex]

Updated:

• Use memmap
• Fix clippy warnings
• Remove unrelated style changes

[alex]

Failures don't look connected to this PR.

[Xuanwo]

Failures don't look connected to this PR.

Reruned (freebsd has known issues which not fixed yet, please ignore)

[Xuanwo]

Thanks a lot!

[alex]

Thanks for the review + merge!

Is there a plan for when the next sccache release will be?

[sylvestre]

voila @alex :)
https://github.com/mozilla/sccache/releases/tag/v0.5.1

I am curious why you need this PR to be in a release?

[alex]

Thank you!

…

On Thu, Jun 1, 2023 at 6:08 AM Sylvestre Ledru ***@***.***> wrote: voila @alex <https://github.com/alex> :) https://github.com/mozilla/sccache/releases/tag/v0.5.1 I am curious why you need this PR to be in a release? — Reply to this email directly, view it on GitHub <#1776 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBETX26I4AN6G2ED5HTXJBSZBANCNFSM6AAAAAAYQXJLLE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- All that is necessary for evil to succeed is for good people to do nothing.