-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/rust: cargo toml as part of hash #719
Conversation
Solves a corner case when a procmacro relies upon Cargo.toml availability to retrieve crate aliases from Cargo.toml. Issue: mozilla#676 Side effects: Cache invalidation on Cargo.toml comment changes, the hash changes and as such the cache breaks.
Causes false negatives when Cargo.toml changed, cache lookups will still succeed.
8a4b6cb
to
525ceab
Compare
Besides the merge conflicts, I'd still be interested in getting some feedback here :) |
Can you detail the reason behind this PR? |
Until I get around to impl rust-lang/rust#73921 this was an initial workaround to make sccache usable for builds like https://github.com/paritytech/substrate which needs to resolve |
Closing per #719 (comment) |
A questionable addition, regarding adding
Cargo.toml
to the assets for distributed compiles and also make it part of the hash lookup key.Causes cache invalidation on Cargo.toml change, which is probably not anticipated.
Issue #675 - additive Cargo.toml for each rust dist compile request makes not too much sense right now, the negative impact is pretty big for a config key change