Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make Event::new take enumerated values instead of booleans (fixes #3643)
- Loading branch information
Showing
4 changed files
with
25 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5080c0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from Manishearth
at https://github.com/ttaubert/servo/commit/5080c0d86e4f3388f78fff535d746c51a757b618
5080c0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging ttaubert/servo/issue/3643-event-new-enums = 5080c0d into auto
5080c0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ttaubert/servo/issue/3643-event-new-enums = 5080c0d merged ok, testing candidate = b14594d
5080c0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://build.servo.org/builders/linux/builds/218
failure: http://build.servo.org/builders/mac/builds/223
5080c0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from Manishearth
at https://github.com/ttaubert/servo/commit/5080c0d86e4f3388f78fff535d746c51a757b618
5080c0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging ttaubert/servo/issue/3643-event-new-enums = 5080c0d into auto
5080c0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ttaubert/servo/issue/3643-event-new-enums = 5080c0d merged ok, testing candidate = e59d459
5080c0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://build.servo.org/builders/mac/builds/224
5080c0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from Manishearth
at https://github.com/ttaubert/servo/commit/5080c0d86e4f3388f78fff535d746c51a757b618
5080c0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging ttaubert/servo/issue/3643-event-new-enums = 5080c0d into auto
5080c0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ttaubert/servo/issue/3643-event-new-enums = 5080c0d merged ok, testing candidate = 2f31630
5080c0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://build.servo.org/builders/linux/builds/221
failure: http://build.servo.org/builders/mac/builds/226
5080c0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bors: retry
5080c0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from Manishearth
at https://github.com/ttaubert/servo/commit/5080c0d86e4f3388f78fff535d746c51a757b618
5080c0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging ttaubert/servo/issue/3643-event-new-enums = 5080c0d into auto
5080c0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ttaubert/servo/issue/3643-event-new-enums = 5080c0d merged ok, testing candidate = 293e06f
5080c0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://build.servo.org/builders/linux/builds/249
success: http://build.servo.org/builders/mac/builds/255
5080c0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 293e06f