Skip to content

Commit

Permalink
style: Include the 'unsafe' keyword in serializations of css-align pr…
Browse files Browse the repository at this point in the history
…operties.

Previously we'd omit it since it was merely an explicit way of requesting the
default behavior.  But the spec has changed such that it's not necessarily
equivalent to the default anymore:
https://drafts.csswg.org/css-align/#overflow-values

(Technically the behaviors are probably still equivalent in our implementation,
pending bug 1451380, but we don't have to publicize that via our
serialization.)

Differential Revision: https://phabricator.services.mozilla.com/D14599
  • Loading branch information
dholbert authored and emilio committed Dec 16, 2018
1 parent 3d78025 commit ee6bf98
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions components/style/values/specified/align.rs
Expand Up @@ -92,8 +92,7 @@ impl ToCss for AlignFlags {
dest.write_char(' ')?;
},
AlignFlags::SAFE => dest.write_str("safe ")?,
// Don't serialize "unsafe", since it's the default.
AlignFlags::UNSAFE => {},
AlignFlags::UNSAFE => dest.write_str("unsafe ")?,
_ => {
debug_assert_eq!(extra_flags, AlignFlags::empty());
},
Expand Down

0 comments on commit ee6bf98

Please sign in to comment.