Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private gfx type RenderContext is exposed in several public APIs #2105

Closed
jdm opened this issue Apr 14, 2014 · 0 comments
Closed

Private gfx type RenderContext is exposed in several public APIs #2105

jdm opened this issue Apr 14, 2014 · 0 comments

Comments

@jdm
Copy link
Member

jdm commented Apr 14, 2014

RenderContext is a public member of the private render_context module. It's used as an argument for Font::draw_text_into_context and display_list::draw_into_context, which are public methods used in other gfx modules. The proper way to solve this is via public traits in private modules like render_context, I guess, so the type doesn't leak into publically-exported types and interfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants