Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GetOwnPropertyNames proxy trap #2215

Closed
jdm opened this issue Apr 23, 2014 · 1 comment
Closed

Implement GetOwnPropertyNames proxy trap #2215

jdm opened this issue Apr 23, 2014 · 1 comment
Labels
A-content/bindings The DOM bindings

Comments

@jdm
Copy link
Member

jdm commented Apr 23, 2014

servo/rust-mozjs#33 is relevant. So is BaseDOMProxyHandler::getOwnPropertyNames and CGDOMJSProxyHandler_ownPropNames.
@jdm jdm mentioned this issue Apr 23, 2014
Closed
@frewsxcv
Copy link
Contributor

Relevant to #6390

frewsxcv added a commit to frewsxcv/servo that referenced this issue Aug 17, 2015
@frewsxcv
Initial implementation of ownPropertyKeys proxy handler
9d98e27 
Generates `SupportedPropertyNames` on DOM structs that should implement
it. Most of them are unimplemented now (which can be implemented in
later PRs), with the exception of `HTMLCollection`. Also added a couple
relevant WPT tests.

Closes servo#6390

Closes servo#2215
@frewsxcv frewsxcv mentioned this issue Aug 17, 2015
Merged
frewsxcv added a commit to frewsxcv/servo that referenced this issue Aug 17, 2015
@frewsxcv
Initial implementation of ownPropertyKeys proxy handler
c969506 
Generates `SupportedPropertyNames` on DOM structs that should implement
it. Most of them are unimplemented now (which can be implemented in
later PRs), with the exception of `HTMLCollection`. Also added a couple
relevant WPT tests.

Closes servo#6390

Closes servo#2215
frewsxcv added a commit to frewsxcv/servo that referenced this issue Aug 17, 2015
@frewsxcv
Initial implementation of ownPropertyKeys proxy handler
f5dc1e7 
Generates `SupportedPropertyNames` on DOM structs that should implement
it. Most of them are unimplemented now (which can be implemented in
later PRs), with the exception of `HTMLCollection`. Also added a couple
relevant WPT tests.

Closes servo#6390

Closes servo#2215
frewsxcv added a commit to frewsxcv/servo that referenced this issue Aug 18, 2015
@frewsxcv
Initial implementation of ownPropertyKeys proxy handler
14e7692 
Generates `SupportedPropertyNames` on DOM structs that should implement
it. Most of them are unimplemented now (which can be implemented in
later PRs), with the exception of `HTMLCollection`. Also added a couple
relevant WPT tests.

Closes servo#6390

Closes servo#2215
frewsxcv added a commit to frewsxcv/servo that referenced this issue Aug 18, 2015
@frewsxcv
Initial implementation of ownPropertyKeys proxy handler
54da950 
Generates `SupportedPropertyNames` on DOM structs that should implement
it. Most of them are unimplemented now (which can be implemented in
later PRs), with the exception of `HTMLCollection`. Also added a couple
relevant WPT tests.

Closes servo#6390

Closes servo#2215
frewsxcv added a commit to frewsxcv/servo that referenced this issue Aug 19, 2015
@frewsxcv
Initial implementation of ownPropertyKeys proxy handler
67aacb5 
Generates `SupportedPropertyNames` on DOM structs that should implement
it. Most of them are unimplemented now (which can be implemented in
later PRs), with the exception of `HTMLCollection`. Also added a couple
relevant WPT tests.

Closes servo#6390

Closes servo#2215
frewsxcv added a commit to frewsxcv/servo that referenced this issue Aug 19, 2015
@frewsxcv
Initial implementation of ownPropertyKeys proxy handler
ef791fe 
Generates `SupportedPropertyNames` on DOM structs that should implement
it. Most of them are unimplemented now (which can be implemented in
later PRs), with the exception of `HTMLCollection`. Also added a couple
relevant WPT tests.

Closes servo#6390

Closes servo#2215
frewsxcv added a commit to frewsxcv/servo that referenced this issue Aug 19, 2015
@frewsxcv
Initial implementation of ownPropertyKeys proxy handler
c71ae23 
Generates `SupportedPropertyNames` on DOM structs that should implement
it. Most of them are unimplemented now (which can be implemented in
later PRs), with the exception of `HTMLCollection`. Also added a couple
relevant WPT tests.

Closes servo#6390

Closes servo#2215
frewsxcv added a commit to frewsxcv/servo that referenced this issue Aug 19, 2015
@frewsxcv
Initial implementation of ownPropertyKeys proxy handler
46c1aa7 
Generates `SupportedPropertyNames` on DOM structs that should implement
it. Most of them are unimplemented now (which can be implemented in
later PRs), with the exception of `HTMLCollection`. Also added a couple
relevant WPT tests.

Closes servo#6390

Closes servo#2215
frewsxcv added a commit to frewsxcv/servo that referenced this issue Aug 20, 2015
@frewsxcv
Initial implementation of ownPropertyKeys proxy handler
b6355c7 
Generates `SupportedPropertyNames` on DOM structs that should implement
it. Most of them are unimplemented now (which can be implemented in
later PRs), with the exception of `HTMLCollection`. Also added a couple
relevant WPT tests.

Closes servo#6390

Closes servo#2215
frewsxcv added a commit to frewsxcv/servo that referenced this issue Aug 20, 2015
@frewsxcv
Initial implementation of ownPropertyKeys proxy handler
aca8e1a 
Generates `SupportedPropertyNames` on DOM structs that should implement
it. Most of them are unimplemented now (which can be implemented in
later PRs), with the exception of `HTMLCollection`. Also added a couple
relevant WPT tests.

Closes servo#6390

Closes servo#2215
bors-servo pushed a commit that referenced this issue Aug 20, 2015
Auto merge of #7254 - frewsxcv:own-property-keys, r=Ms2ger
8b7eb77 
Initial implementation of ownPropertyKeys proxy handler

Generates `SupportedPropertyNames` on DOM structs that should implement
it. Most of them are unimplemented now (which can be implemented in
later PRs), with the exception of `HTMLCollection`. Also added a couple
relevant WPT tests.

Closes #6390

Closes #2215 

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7254)
<!-- Reviewable:end -->
frewsxcv added a commit to frewsxcv/servo that referenced this issue Aug 20, 2015
@frewsxcv
Initial implementation of ownPropertyKeys proxy handler
b11be4d 
Generates `SupportedPropertyNames` on DOM structs that should implement
it. Most of them are unimplemented now (which can be implemented in
later PRs), with the exception of `HTMLCollection`. Also added a couple
relevant WPT tests.

Closes servo#6390

Closes servo#2215
bors-servo pushed a commit that referenced this issue Aug 20, 2015
Auto merge of #7254 - frewsxcv:own-property-keys, r=Ms2ger
d2a8c27 
Initial implementation of ownPropertyKeys proxy handler

Generates `SupportedPropertyNames` on DOM structs that should implement
it. Most of them are unimplemented now (which can be implemented in
later PRs), with the exception of `HTMLCollection`. Also added a couple
relevant WPT tests.

Closes #6390

Closes #2215 

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7254)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/bindings The DOM bindings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdm @frewsxcv