This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Update README to prepare for archival #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliandescottes
approved these changes
Jun 22, 2022
README.md
Outdated
Comment on lines
5
to
7
| ## Sources | ||
|
|
||
| - Chrome Devtools: [emulated_devices/module.json](https://source.chromium.org/chromium/chromium/src/+/master:third_party/devtools-frontend/src/front_end/emulated_devices/module.json). |
There was a problem hiding this comment.
I wanted to keep it for future reference, just in case, but it'd probably be better to just remove it and add the link into firefox doc
README.md
Outdated
| - Submit [pull requests](https://github.com/jankeromnes/devices/pulls). | ||
|
|
||
| `devices.json` is a catalog of common web-enabled devices and their properties, that was previously used by the Responsive Design Mode in Firefox DevTools. | ||
| The data now lives in Mozilla's RemoteSettings `devtools-devices` collection, see https://firefox-source-docs.mozilla.org/devtools/responsive/devices.html for more information |
There was a problem hiding this comment.
Suggested change
| The data now lives in Mozilla's RemoteSettings `devtools-devices` collection, see https://firefox-source-docs.mozilla.org/devtools/responsive/devices.html for more information | |
| The data now lives in Mozilla's RemoteSettings `devtools-devices` collection, see https://firefox-source-docs.mozilla.org/devtools/responsive/devices.html for more information. |
nitpick: missing dot.
|
Thanks for the review @juliandescottes , I addressed the comments and will merge this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.