Bug 1183377: Document additional tracking events. #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Requests sent to snippets-stats.mozilla.org contain the following data in | ||
| addition to the normal data available from an HTTP request: | ||
| Requests sent to snippets-stats.mozilla.org contain the following data (sent as | ||
| JSON in the body of the request) in addition to the normal data available from |
There was a problem hiding this comment.
data are sent as url parameters e.g. foo.html?snippet_id=12&metric=foo
|
besides the json nit, looks good. thanks @Osmose |
|
Crap, so I accidentally merged the branch from #120 rather than the branch for this PR. Luckily, that branch was rebased on this one already, so I just had to revert 72f378d (reverted in efe186d) and then add a commit with the JSON->URL params fix (6fd860d). I'll open a new PR with the privacy changes to replace #120. Sorry for the mixup. :\ |
|
Ha I thought you would figure out figure merging due to my duplicate comments, no worries :) Don't forget to open the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problems pointed out by bsmedberg in bug 1183377.
@glogiotatidis r?