This repository has been archived by the owner on Jan 31, 2019. It is now read-only.
set up puppet so launch configs work, including using singular name for ... #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| mode => 600, | ||
| owner => root, | ||
| group => root, | ||
| source => 'puppet:///modules/socorro/files/etc_cron.d/socorro' |
There was a problem hiding this comment.
Will this work ok with masterless puppet? Not sure how to specify the path here if not (obv. I haven't tested this role either :) )
|
@phrawzty OK I read up on it a bit and fixed up the admin role. I went ahead and tested all socorro-specific roles (everything but ES, PG, Consul) and this seems to work fine for all of them, with the latest socorro RPM in the repo (which is built from my |
|
Looks good. There are just some style nits to fix, though: lines 140-144 of the Travis run are |
|
Also: suggest adding |
…or roles consistently
rhelmer
force-pushed
the
make-launch-configs-work
branch
from
672d61f
to
fd825a4
Compare
rhelmer
added a commit
that referenced
this pull request
Mar 23, 2015
set up puppet so launch configs work, including using singular name for ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...roles consistently
r? @phrawzty - I've only tested collector so far, which seems to WFM with these changes.