Skip to content
This repository has been archived by the owner on Jan 31, 2019. It is now read-only.

Change latest to installed for socorro packages #84

Closed
wants to merge 1 commit into from

Conversation

jdotpz
Copy link
Contributor

@jdotpz jdotpz commented May 4, 2015

This is meant to address this scenario:

  • v1.0.1 is in production, v1.0.2 is in staging being tested/updated
  • We scale in a new node into a production cluster
  • The new production node has v1.0.1 baked in on instantiation
  • Puppet runs on the new production node, upping it to v1.0.2 despite that not being cleared for prod

This will mean we will have to use a base AMI (currently used) for the build instead of querying the AWS API for the latest staging AMI. Otherwise, it would not install the updated version while making an AMI for staging and eventual production.

@phrawzty
Copy link
Contributor

phrawzty commented May 6, 2015

That's a clever solution to the problem - good thinking!

@@ -28,7 +28,7 @@

package {
'socorro':
ensure=> latest;
ensure=> installed;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put a space between the keyword and the fat arrow, i.e.

    ensure => installed

Not sure why the linter didn't catch this.

Same same for the other manifests in this PR.

r+ once this is fixed.

@jdotpz
Copy link
Contributor Author

jdotpz commented May 6, 2015

Rob has a more clever option actually, which is to only do a package install on the packer run, not the base puppet repo. That seems a bit more ideal.

@phrawzty
Copy link
Contributor

phrawzty commented May 6, 2015

Up to you whether you want to fix and merge or just close, then. I leave it with @rhelmer and you to decide.

@rhelmer
Copy link
Contributor

rhelmer commented May 6, 2015

I think latest versus installed shouldn't make any difference given #86.

@rhelmer rhelmer closed this May 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants