This repository has been archived by the owner on Jan 25, 2018. It is now read-only.
no need for solitude proxy any more #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andymckay
commented
Jul 20, 2015
andymckay
commented
- things go through solitude-auth now, so remove the second process inside the solitude container
- set the default in settings to solitude-auth for docker to save another env variable
- fixes Remove solitude-proxy from docker #515
|
looks like the tests might be missing some config |
| with self.settings(ZIPPY_MOCK=False): | ||
| eq_(ProxyView().dispatch(req, reference_name='bob', | ||
| resource_name='sellers').status_code, 404) | ||
| with self.assertRaises(KeyError): |
There was a problem hiding this comment.
what is this test doing? Do we still need it? I can't decipher from the test name what it's testing.
|
r+wc |
andymckay
pushed a commit
that referenced
this pull request
Aug 6, 2015
no need for solitude proxy any more
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.