This repository has been archived by the owner on Jan 25, 2018. It is now read-only.
turn on atomic requests on prod #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,6 +13,7 @@ | |||
| def custom_exception_handler(exc): | |||
| # If you raise an error in solitude, it comes to here and | |||
| # we rollback the transaction. | |||
| log.exception('Handling exception, about to roll back') | |||
There was a problem hiding this comment.
I'm not sure that it's safe to do this because even though it logs the last exception in the system stack, Django might have caught something innocuous (like a KeyError) already.
There was a problem hiding this comment.
I think you should log exc directly
There was a problem hiding this comment.
That seems legit, will do.
|
r+wc |
andymckay
pushed a commit
that referenced
this pull request
Aug 6, 2015
turn on atomic requests on prod
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DATABASES['default']is being overridden, meaning we weren't in an atomic block although the code assumed that