Fix source-map breaking on PhantomJS where bind isn't available #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhantomJS (1.9.1 and below) does not provides the `Function.prototype.bind` method. Since PhantomJS is already used in production in CI environment such TravisCI it may be simpler for source-map to have a shim rather than waiting for PhantomJS to fix that.
|
The source-map library supports ES5 environments. If phantom js isn't an ES5 environment, it is up to them to become one. In the meantime, you can add that polyfill to your grunt build or whatever equivalent you're using. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhantomJS (1.9.1 and below) does not provides the
Function.prototype.bindmethod. Since PhantomJS is alreadyused in production in CI environment such TravisCI it may be simpler for source-map to have a shim rather than waiting for
PhantomJS to fix that.