Make the file property optional #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'Tried to fall back on the file property of the source map ' + | ||
| 'to apply (since the second argument was omitted), but it ' + | ||
| 'was not set.' | ||
| ); |
There was a problem hiding this comment.
How about something like
throw new Error(
'SourceMapGenerator.prototype.applySourceMap requires either an explicit source file, ' +
'or the source map\'s "file" property. Both were omitted.'
);
There was a problem hiding this comment.
Yeah, that sounds better. But really I'd like to deprecate omitting the second parameter. How can we warn users? console.warn? Or is that a separate pull request?
There was a problem hiding this comment.
File an issue first to open discussion. My reaction at this moment in time is that nothing needs to be deprecated.
|
Looks good, will merge once the error message is a little more clear, as mentioned above. |
|
I've amended your improved error message now. |
fitzgen
added a commit
that referenced
this pull request
Feb 15, 2014
Make the file property optional
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.