Convert Travis to Docker and autodeploy stage #41
Conversation
|
@willkg this should be pretty much just like the webapp. I removed docker-compose because it's not necessary since we only need the one container. Seems like the Makefile is a good enough place to put all of the commands and stuff. We can discuss further here though. |
pmac
force-pushed
the
travis-use-docker
branch
from
72b6a73
to
340da2c
Compare
|
This is fine by me. Does it help to wait on this until after we've merged standups and rogerroger? |
| touch .docker-build | ||
|
|
||
| run: .docker-build | ||
| ${DOCKERCOMPOSE} up irc | ||
| docker run --env-file .env_dev -v "$PWD:/app" standup_irc |
There was a problem hiding this comment.
This doesn't account for the postgres requirement. Though maybe we don't need a run rule at all?
There was a problem hiding this comment.
hmm... there wasn't a postgres service setup in the docker-compose.yml file. I don't really think it's very useful locally, though I could see an argument for having that option. I think the bot does just fine w/o a DB if there isn't one, though testing the DB stuff is important. This is a good question. Perhaps we should keep the compose file even if we don't use it in the Makefile for when one might want to do a full-stack run locally. Or is it possible to switch over to SQLite for local?
There was a problem hiding this comment.
I read through the code and the pg stuff is optional. If it's there, then standup-irc will persist things like joined channels. If not, no big deal.
That covers my thoughts.
pmac
force-pushed
the
travis-use-docker
branch
from
340da2c
to
1cef087
Compare
|
This looks good to me. r+ I'll let you merge it if/when you're comfortable. |
No description provided.