Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit card expiration year validation is not working properly #2196

Closed
bsurd opened this issue Aug 14, 2019 · 3 comments
Closed

Credit card expiration year validation is not working properly #2196

bsurd opened this issue Aug 14, 2019 · 3 comments
Labels
severity:minor Label for QA to mark minor issues logged status:bug status:wontfix

Comments

@bsurd
Copy link

bsurd commented Aug 14, 2019

Affected versions:

  • All Firefox

Affected Platforms:

  • All Windows

Steps to reproduce

  1. Go to 123done.
  2. Sign in/up with an account.
  3. Click on "Subscribe to Pro".
  4. Enter any valid card number.
  5. In the "Exp. date" field enter a date that is more than 4 years past the current date. (eg. 08/24)

Expected result:

An error is displayed informing the user that the expiration year is invalid.

Actual result:

No error is displayed.

Notes:

As most cards have a valid period of 4 years any date that is past that should return an error.
Currently, the error is displayed only when entering a very distant year in the future eg. xx/70

image

@marty331
Copy link
Contributor

@bsurd Here is the repo - https://github.com/mozilla/fxa
Please recreate there.

@bbangert bbangert reopened this Aug 14, 2019
@bbangert bbangert transferred this issue from mozilla/subhub Aug 14, 2019
@bsurd bsurd added severity:minor Label for QA to mark minor issues logged status:bug labels Aug 14, 2019
@clouserw
Copy link
Member

The payment provider should be determining the validity of a credit card number. As you mention, "most cards have a valid period of 4 years" -- if a card issuer decides to change their system we shouldn't need to make a change in our front-end code.

I recommend wontfix. @johngruen ?

@johngruen
Copy link
Contributor

Agree with @clouserw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:minor Label for QA to mark minor issues logged status:bug status:wontfix
Projects
None yet
Development

No branches or pull requests

5 participants