Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some buttons are no longer displayed after you select "Community Discussion Only" section [Search Pages] #128

Closed
ovidiuboca1 opened this issue Jan 27, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ovidiuboca1
Copy link

STR:

  1. Go to https://test.sumo.mozit.cloud/en-US/
    2 In the search field type "cookies"
  2. Select "Community Discussion Only" section

ER: The section is selected and the other 2 sections "Show Everything", "Help Articles Only" are still displayed and actionable.
AR: The "Show Everything" and "Help Articles Only" sections are no longer displayed.

@ovidiuboca1 ovidiuboca1 added the bug Something isn't working label Jan 27, 2020
@ovidiuboca1 ovidiuboca1 added this to the Responsive redesign milestone Jan 27, 2020
@kkellydesign
Copy link

From what I can tell, this is how it works in production as well, but it's tough to find because the index is so much larger in production. The issue that you're seeing is that there are no search results that match "cookie" in the community discussion forum, so that result is turning up the "no results" screen. The "no results" screen doesn't have the tab bar, because there's no sense in filtering "zero" results. The results that you are seeing in your community discussion tab here is the default list when no results are displayed, with the heading "We couldn't find any results for ‘cookies’ in ‘English’. Maybe one of these articles will be helpful?"

If you'd like to see this working properly, type the search term "outlook." There is a community discussion that matches that query, so you'll see all three tabs working correctly there.

@ovidiuboca1
Copy link
Author

I understand your opinion, but the problem is when a user will search after a term that doesn't have any result in the "Community Discussion Only" section but this section will be displayed and the user will click on it(because is clickable even though it doesn't have any results)and it will be stuck there and it will not be possible to go back on the previous state. Also, it doesn't help you to click on the back button form the browser. The idea is that the user if will click on the "Community Discussion Only" section, will end up in a place that doesn't have any option to go back. Maybe if there are no results it will be a good idea to make that button unactionable.

@kkellydesign
Copy link

Yeah, I agree that the UX is poor around this, and needs some more thought. I didn't mean to sound argumentative – my point was just that it's not a regression based on the new design work. These issues are still helpful to log for the next round.

@akatsoulas akatsoulas modified the milestones: Responsive redesign, Responsive Redesign V2 Mar 10, 2020
@akatsoulas akatsoulas modified the milestones: Responsive Redesign V2, ElasticSearch7 Sep 11, 2020
@akatsoulas akatsoulas added this to the Search and Queries implementation milestone Sep 21, 2020
@akatsoulas akatsoulas modified the milestones: Search and Queries implementation, New Sumo Search - phase 1 Jan 26, 2021
@LeoMcA LeoMcA self-assigned this Feb 17, 2021
@mirunacurtean
Copy link
Collaborator

Verified fixed across tests for #131, #169 and #714 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants