-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The "Log In/Sign up" button is replaced with a different icon - on Mobile devices #20
Comments
The icon that you see is the default 'gravatar' icon for when a user isn't logged in. When it's clicked, you should get this: However the testing server is throwing some errors that I'm not getting locally: @akatsoulas I would guess this is related to the Protocol static files not being pulled into the static directory, as the error I'm seeing on the test server is this: Once a user is logged in and they have a gravatar, that will be their own photo, like this: |
I'll note that I can wrap a conditional around this icon to display a different default design if the user is logged out, and that will look a little nicer. I know I've seen a nice color version of this icon, but I can't seem to find it: @jess-cook03, if you could dig up a PNG or SVG for me, I can use that instead. |
This is ready to be tested again. https://test.sumo.mozit.cloud/en-US/ The JS is working now, and when logged out, the mozilla avatar is used instead of the default gravatar. Note though that when you're logged in, IF you're on a sumo account with an e-mail address that doesn't have a gravatar assigned, you'll see the gravatar default, as in the screenshot above. Here's a screenshot of the current logged-out view: |
I verified this on mobile devices with iOS and Android and the issue is fixed. |
STR:
Prerequisites: Open the Firefox browser in RDM mode. Menu -> Web Developer -> select Responsive Desing Mode -> select a mobile device, iPhone X for example
STR:
ER: The "Log In/Sign up" button is still there.
AR: The "Log In/Sign up" button is replaced with a different icon.
NOTE: This issue is similar to this one https://github.com/mozilla/kitsune/issues/4078
The text was updated successfully, but these errors were encountered: