Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Log In/Sign up" button is replaced with a different icon - on Mobile devices #20

Closed
ovidiuboca1 opened this issue Dec 13, 2019 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ovidiuboca1
Copy link

STR:

Prerequisites: Open the Firefox browser in RDM mode. Menu -> Web Developer -> select Responsive Desing Mode -> select a mobile device, iPhone X for example

STR:

  1. Go to Support Mozilla page

ER: The "Log In/Sign up" button is still there.
AR: The "Log In/Sign up" button is replaced with a different icon.

NOTE: This issue is similar to this one https://github.com/mozilla/kitsune/issues/4078

@akatsoulas akatsoulas transferred this issue from mozilla/kitsune Dec 20, 2019
@akatsoulas akatsoulas added the bug Something isn't working label Dec 20, 2019
@akatsoulas akatsoulas added this to the Responsive redesign milestone Dec 20, 2019
@kkellydesign
Copy link

The icon that you see is the default 'gravatar' icon for when a user isn't logged in.

Screen Shot 2020-01-17 at 4 43 07 PM

When it's clicked, you should get this:
Screen Shot 2020-01-17 at 5 31 02 PM

However the testing server is throwing some errors that I'm not getting locally: @akatsoulas I would guess this is related to the Protocol static files not being pulled into the static directory, as the error I'm seeing on the test server is this:
Screen Shot 2020-01-17 at 5 33 19 PM

Once a user is logged in and they have a gravatar, that will be their own photo, like this:
Screen Shot 2020-01-17 at 4 42 17 PM

And then when that is clicked, you get this:
Screen Shot 2020-01-17 at 5 14 56 PM

@kkellydesign
Copy link

I'll note that I can wrap a conditional around this icon to display a different default design if the user is logged out, and that will look a little nicer. I know I've seen a nice color version of this icon, but I can't seem to find it:
Screen Shot 2020-01-17 at 5 42 00 PM

@jess-cook03, if you could dig up a PNG or SVG for me, I can use that instead.

@kkellydesign
Copy link

This is ready to be tested again. https://test.sumo.mozit.cloud/en-US/

The JS is working now, and when logged out, the mozilla avatar is used instead of the default gravatar. Note though that when you're logged in, IF you're on a sumo account with an e-mail address that doesn't have a gravatar assigned, you'll see the gravatar default, as in the screenshot above. Here's a screenshot of the current logged-out view:

Screen Shot 2020-02-11 at 10 46 02 AM

@ovidiuboca1
Copy link
Author

I verified this on mobile devices with iOS and Android and the issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants