Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/sentry #148

Merged
merged 5 commits into from
Feb 20, 2019
Merged

Features/sentry #148

merged 5 commits into from
Feb 20, 2019

Conversation

crankycoder
Copy link
Contributor

This adds:

  • sentry logging to taar
  • more exception handling around each of the recommend methods in each of collaborative, locale, similarity and ensemble recommenders
  • forced_expiry() for LazyS3JSON
  • forced reload of models on recommendation exception
  • tests around the LazyS3 loader

I've added an exception handler that forces reload of underlying model in the case of recommendation error.
Extra exception logging occurs if any recommender crashes
@crankycoder crankycoder merged commit c6f4d1a into mozilla:master Feb 20, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.05%) to 87.444% when pulling 0017697 on crankycoder:features/sentry into 65ea676 on mozilla:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants