This repository has been archived by the owner on Mar 5, 2020. It is now read-only.
Preparing router context for migration
#1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR looks good to me. I wish there's some built-in router icon that I could attach here though. 😜 |
|
hmm... 🚃🚃🚃🚃🚃 ? |
…. This will make updating to the new react-router considerably easier
Pomax
added a commit
that referenced
this pull request
Feb 4, 2016
Preparing `router` context for migration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup around how the Page and current router are used in the code, and the router context (which is
this.props.routerin react-router 1.0)These changes pass all tests, but there are warnings about setState() for the Select component being called while it's not mounted. This suggests that the modal for it expires during testing, but it also doesn't seem to affect testing, so something odd is going on here.
Note that some files were touched in order to make the test log less polluted.